jessegrabowski / gEconpy

A collection of tools for working with DSGE models in python, inspired by the R package gEcon
https://geconpy.readthedocs.io/en/latest/index.html
GNU General Public License v3.0
23 stars 3 forks source link

Improving test coverage #30

Closed jessegrabowski closed 1 year ago

jessegrabowski commented 1 year ago

The objective of this PR is to get to 100% test coverage on the existing code base!

Closes #22

codecov[bot] commented 1 year ago

Codecov Report

Merging #30 (5a35d3f) into main (682a9b0) will increase coverage by 23.38%. The diff coverage is 91.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #30       +/-   ##
===========================================
+ Coverage   56.71%   80.09%   +23.38%     
===========================================
  Files          38       37        -1     
  Lines        5059     5129       +70     
===========================================
+ Hits         2869     4108     +1239     
+ Misses       2190     1021     -1169     
Impacted Files Coverage Δ
gEconpy/estimation/estimation_utilities.py 91.58% <50.00%> (+32.61%) :arrow_up:
gEconpy/shared/statsmodel_convert.py 80.69% <50.00%> (+77.17%) :arrow_up:
gEconpy/solvers/perturbation.py 98.21% <50.00%> (+3.29%) :arrow_up:
gEconpy/solvers/steady_state.py 62.94% <81.63%> (-0.05%) :arrow_down:
gEconpy/solvers/gensys.py 83.04% <83.33%> (+3.04%) :arrow_up:
gEconpy/estimation/estimate.py 73.50% <85.29%> (+24.10%) :arrow_up:
gEconpy/classes/containers.py 97.07% <90.76%> (+8.42%) :arrow_up:
gEconpy/classes/model.py 91.74% <91.75%> (+33.38%) :arrow_up:
gEconpy/sampling/prior_utilities.py 91.39% <96.00%> (+81.61%) :arrow_up:
gEconpy/plotting/plotting.py 99.35% <97.43%> (+90.26%) :arrow_up:
... and 6 more

... and 9 files with indirect coverage changes

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

jessegrabowski commented 1 year ago

Up to 80% coverage. That's going to have to be good enough for now, since the major estimation refactoring is pending and I don't want to write extensive tests for code that is going to be removed soon. Merging and closing this, I'll re-open a new issues pertaining to the last 20%.