search

jessegrosjean / quickcursor

496 stars 74 forks source link

Added "Insert Only" mode to QuickCursor #25

Closed rgraciano closed 12 years ago

rgraciano commented 12 years ago

My last commit message sums up this change pretty well. This is a substantial upgrade, in that it enables an additional workflow (one I use frequently - email). Hope you find it useful! Let me know if you have any questions. Also if you do make use of this, I'd appreciate a footnote someplace mentioning my name as a contributor.

Best, -Ryan

Commit message:

Currently, QuickCursor always copies all text from the target window
before opening the external editor.  After the editor is opened and
the text is edited, QuickCursor eliminates everything from the original
buffer in the paste.

This is not so great if you are, say, replying to an email and only want
to edit your response in the external editor without destroying the rest
of the email chain.  Hence, "insert" - "insert" will NOT copy or select
the buffer before opening the external editor.  It'll just open up the
editor, and upon save/quit, it'll paste the text back in at the cursor.

While I was in there, I also made one or two minor enhancements.
Now, if you pick a shortcut that is already in use, the app will
look through the existing shortcuts and remove dupes. This also
works with the Edit/Insert feature; the app will actually pull the
dupe shortcut out of the other control if it's currently displaying.

This is the first thing I have ever done in Objective-C, so
apologies if I'm slightly off on common idioms and that sort of
thing.
jessegrosjean commented 12 years ago

Ryan,

Thanks for this. I'm sorry I still haven't had a chance to look very closely at it (and it might be a few weeks still), but it's on my list and I will get to it eventually. Thanks again, sorry I'm being slow about it.

Jesse

On Sat, Dec 10, 2011 at 2:11 PM, Ryan Graciano reply@reply.github.com wrote:

My last commit message sums up this change pretty well.  This is a substantial upgrade, in that it enables an additional workflow (one I use frequently - email).  Hope you find it useful!  Let me know if you have any questions.  Also if you do make use of this, I'd appreciate a footnote someplace mentioning my name as a contributor.

Best, -Ryan

Commit message:

   Currently, QuickCursor always copies all text from the target window    before opening the external editor.  After the editor is opened and    the text is edited, QuickCursor eliminates everything from the original    buffer in the paste.

   This is not so great if you are, say, replying to an email and only want    to edit your response in the external editor without destroying the rest    of the email chain.  Hence, "insert" - "insert" will NOT copy or select    the buffer before opening the external editor.  It'll just open up the    editor, and upon save/quit, it'll paste the text back in at the cursor.

   While I was in there, I also made one or two minor enhancements.    Now, if you pick a shortcut that is already in use, the app will    look through the existing shortcuts and remove dupes. This also    works with the Edit/Insert feature; the app will actually pull the    dupe shortcut out of the other control if it's currently displaying.

   This is the first thing I have ever done in Objective-C, so    apologies if I'm slightly off on common idioms and that sort of    thing.

You can merge this Pull Request by running:

 git pull https://github.com/rgraciano/quickcursor master

Or you can view, comment on it, or merge it online at:

 https://github.com/jessegrosjean/quickcursor/pull/25

-- Commit Summary --

  •     The goal here is to add a new hotkey to QuickCursor: "Insert".

-- File Changes --

M English.lproj/MainMenu.xib (307) M QCAppDelegate.h (28) M QCAppDelegate.m (310) A QCSRDelegate.h (25) A QCSRDelegate.m (47) M QuickCursor.xcodeproj/project.pbxproj (6)

-- Patch Links --

 https://github.com/jessegrosjean/quickcursor/pull/25.patch  https://github.com/jessegrosjean/quickcursor/pull/25.diff

Reply to this email directly or view it on GitHub: https://github.com/jessegrosjean/quickcursor/pull/25

rgraciano commented 12 years ago

No big deal; I wrote it mostly for myself, and I'm already using it :)

On Sat, Dec 17, 2011 at 7:58 AM, Jesse Grosjean < reply@reply.github.com

wrote:

Ryan,

Thanks for this. I'm sorry I still haven't had a chance to look very closely at it (and it might be a few weeks still), but it's on my list and I will get to it eventually. Thanks again, sorry I'm being slow about it.

Jesse

On Sat, Dec 10, 2011 at 2:11 PM, Ryan Graciano reply@reply.github.com wrote:

My last commit message sums up this change pretty well. This is a substantial upgrade, in that it enables an additional workflow (one I use frequently - email). Hope you find it useful! Let me know if you have any questions. Also if you do make use of this, I'd appreciate a footnote someplace mentioning my name as a contributor.

Best, -Ryan

Commit message:

Currently, QuickCursor always copies all text from the target window before opening the external editor. After the editor is opened and the text is edited, QuickCursor eliminates everything from the original buffer in the paste.

This is not so great if you are, say, replying to an email and only want to edit your response in the external editor without destroying the rest of the email chain. Hence, "insert" - "insert" will NOT copy or select the buffer before opening the external editor. It'll just open up the editor, and upon save/quit, it'll paste the text back in at the cursor.

While I was in there, I also made one or two minor enhancements. Now, if you pick a shortcut that is already in use, the app will look through the existing shortcuts and remove dupes. This also works with the Edit/Insert feature; the app will actually pull the dupe shortcut out of the other control if it's currently displaying.

This is the first thing I have ever done in Objective-C, so apologies if I'm slightly off on common idioms and that sort of thing.

You can merge this Pull Request by running:

git pull https://github.com/rgraciano/quickcursor master

Or you can view, comment on it, or merge it online at:

https://github.com/jessegrosjean/quickcursor/pull/25

-- Commit Summary --

  • The goal here is to add a new hotkey to QuickCursor: "Insert".

-- File Changes --

M English.lproj/MainMenu.xib (307) M QCAppDelegate.h (28) M QCAppDelegate.m (310) A QCSRDelegate.h (25) A QCSRDelegate.m (47) M QuickCursor.xcodeproj/project.pbxproj (6)

-- Patch Links --

https://github.com/jessegrosjean/quickcursor/pull/25.patch https://github.com/jessegrosjean/quickcursor/pull/25.diff

Reply to this email directly or view it on GitHub: https://github.com/jessegrosjean/quickcursor/pull/25

Reply to this email directly or view it on GitHub: https://github.com/jessegrosjean/quickcursor/pull/25#issuecomment-3189481

GreyBurkart commented 12 years ago

Thanks again! I'm closing this pull request because we went by the method in pull request 29 by @Xeago -- check it out and see what you think.

rgraciano commented 12 years ago

NP, that other method certainly looks easier to integrate and is less of a change to the UI. It's a good solution. I'll probably keep using my own fork though, because it allows me to both hotkey a select all / edit and an insert at the same time