search

jessegrosjean / quickcursor

496 stars 74 forks source link

Smart insert #29

Closed xeago closed 12 years ago

xeago commented 12 years ago

Add insert functionality in a different way than @rgraciano. Instead of by default selecting all text and copying that into the editor, copy what currently is selected based on user preference and continue as normal.

I added a checkbox in the preference menu, and accidentally deleted the menubar (for which I saw no reason to exist tho..). This approach has less of an impact to the overall structure of the code than @rgraciano's approach and might thus be easier to support. This is as requested in Issue 8, comment from @subtlegradient.

GreyBurkart commented 12 years ago

Thanks, will be taking a look soon!

GreyBurkart commented 12 years ago

@Xeago Nifty bit of work, thanks for letting us know! We tweaked the implementation a bit to make toggling the option require fewer clicks and so on, so check it out and let us know what you think! Thank you again.

xeago commented 12 years ago

Thanks for merging, it looks and feels better this way! Please consider closing @rgraciano's pull request, this achieves the same: insert only.