Fix unsupported characters ń (Issue #46) for "vsts-tfvc-checkin" task.

jessehouwing / azure-pipelines-tfvc-tasks

Azure Pipelines tasks for Team Foundation Version Control

MIT License

27 stars 18 forks source link

Closed angel-gomez-romero closed 6 years ago

angel-gomez-romero commented 7 years ago

There have been issues with in TFVC 2017 user names containing ", " characters.
Solved using "$checkinParameters.Author = $env:BUILD_QUEUEDBYID" instead of "$env:BUILD_QUEUEDBY" build variable.

jessehouwing commented 7 years ago

Have you tested this against VSTS as well?

angel-gomez-romero commented 7 years ago

Hi Jesse, I’ve only tested against TFS.

jessehouwing commented 7 years ago

Any chance you could test it against VSTS as we, I'm about to leave in a 3 week vacation and am limited in time.

angel-gomez-romero commented 7 years ago

Ok Jesse, I’ll try to test depending on my possibilities, providing also information on results if possible.

angel-gomez-romero commented 6 years ago

Finally, I have a VSTS system available to be able to do the necessary tests and the proposed fix is also working fine in VSTS as in TFS.