search

jessehouwing / azure-pipelines-tfvc-tasks

Azure Pipelines tasks for Team Foundation Version Control
https://marketplace.visualstudio.com/items?itemName=jessehouwing.jessehouwing-vsts-tfvc-tasks
MIT License
27 stars 18 forks source link

"I understand" checkbox isn't required #64

Closed ChrisMenegay closed 5 years ago

ChrisMenegay commented 6 years ago

though message indicates it is, I missed seeing it and my stuff checked in fine, but I did get a powershell error in my build log. The comment on the task help probably just needs to be updated.

jessehouwing commented 6 years ago

Ohh yeah. Problem is, setting it required doesn't make it required to be true. So the Ui happily submits false.

On Mon, 16 Apr 2018, 18:07 ChrisMenegay, notifications@github.com wrote:

though message indicates it is, I missed seeing it and my stuff checked in fine, but I did get a powershell error in my build log. The comment on the task help probably just needs to be updated.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jessehouwing/vsts-tfvc-tasks/issues/64, or mute the thread https://github.com/notifications/unsubscribe-auth/AD-uS7YwrNMsQCdklaR9qHM84dXQw9ZMks5tpMG-gaJpZM4TW0rD .

ChrisMenegay commented 6 years ago

Can't you see that it is false and just immediately throw an error, rather than doing the checkin?