search

jessek / hashdeep

Other
702 stars 132 forks source link

Size mode doesn't limit to ten digits #284

Open jessek opened 11 years ago

jessek commented 11 years ago

The md5deep size mode, -z, doesn't limit the size output to ten digits as claimed in the documentation. This behavior was observed on Fedora 17 x86_64 bit running md5deep version 4.3.

Should we remove the size limit restriction? Enforce it?

simsong commented 11 years ago

What purpose does it serve?

On Mar 19, 2013, at 11:31 AM, Jesse Kornblum notifications@github.com wrote:

The md5deep size mode, -z, doesn't limit the size output to ten digits as claimed in the documentation. This behavior was observed on Fedora 17 x86_64 bit running md5deep version 4.3.

Should we remove the size limit restriction? Enforce it?

— Reply to this email directly or view it on GitHub.

jessek commented 11 years ago

It was written for programs which, in 2004, used fixed sized offsets to find hashes in each line.

simsong commented 11 years ago

Are those programs still in use? On Mar 19, 2013, at 6:12 PM, Jesse Kornblum notifications@github.com wrote:

It was written for programs which, in 2004, used fixed sized offsets to find hashes in each line.

— Reply to this email directly or view it on GitHub.

jessek commented 11 years ago

I don't know.

simsong commented 11 years ago

So what should the program do when a size is larger than 10 digits? Throw an exception?

jessek commented 11 years ago

I'm not aware of any person or program who is using this feature and is limited to ten digits. Let's remove the ten digit restriction and display the full size. If somebody has a problem we can fix it then depending on their needs.