search

jessek / hashdeep

Other
694 stars 130 forks source link

Wrong #if defined in src/helpers.cpp #317

Closed msuhanov closed 10 years ago

msuhanov commented 10 years ago

src/helpers.cpp contains the following line:

if defined (LINUX)

LINUX is not defined in Linux. You should use linux instead:

$ g++ -dM -E - < /dev/null | grep -i linux
#define __linux 1
#define __linux__ 1
#define __gnu_linux__ 1
#define linux 1
simsong commented 10 years ago

Thanks. Now it reads #if defined(__LINUX__) || defined(linux)

msuhanov commented 10 years ago

Thanks. You got it closed before I fixed the problem with a text parser on github :-)

simsong commented 10 years ago

In the future please just submit a pull request. Thanks.