hash.cpp:282: bad if test ?

jessek / hashdeep

Other

694 stars 130 forks source link

Open dcb314 opened 8 years ago

dcb314 commented 8 years ago

hash.cpp:282:20: warning: ordered comparison of pointer with integer zero [-Wextra]

    if(fdht->base>0){

Maybe better code

    if (fdht->base != MAP_FAILED) {

simsong commented 8 years ago

Yes, that would be better. Please submit a pull request.

dcb314 commented 8 years ago

Please submit a pull request.

Sorry, no can do. I am happy for someone else to do one.