search

jessek / hashdeep

Other
702 stars 132 forks source link

Outpur error using DFXML format if filename contains "&" on windows #349

Open excel4 opened 8 years ago

excel4 commented 8 years ago

Fails on version 4.4 hashdeep and md5deep in Windows 7 using -d option

If the file path contains an "&" then the output list includes "&-amp;" instead of "&". Output list is ok without -d option.

example: OK: 4,098f6bcd4621d373cade4e832627b4f6,9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08,e:\tmpn\hashdeep1\dir1&2\foo.txt

Fails with -d option: ...

e:\tmpn\hashdeep1\dir1&-amp;2\foo.txt

...

NOTE: the "-" was inserted between the "&" and "amp" because otherwise the page is rendered incorrectly. The "-" should not be included in the file path.

simsong commented 8 years ago

Neat bug. Thanks for finding it. Can you submit a patch?On May 15, 2016, at 1:31 AM, excel4 notifications@github.com wrote:Fails on version 4.4 hashdeep and md5deep in Windows 7 using -d optionIf the file path contains an "&" then the output list includes "&-amp;" instead of "&". Output list is ok without -d option.example: OK: 4,098f6bcd4621d373cade4e832627b4f6,9f86d081884c7d659a2feaa0c55ad015a3bf4f1b2b0b822cd15d6c15b0f00a08,e:\tmpn\hashdeep1\dir1&2\foo.txtFails with -d option: ... e:\tmpn\hashdeep1\dir1&-amp;2\foo.txt ...NOTE: the "-" was inserted between the "&" and "amp" because otherwise the page is rendered incorrectly. The "-" should not be included in the file path.—You are receiving this because you are subscribed to this thread.Reply to this email directly or view it on GitHub