search

jessek / hashdeep

Other
700 stars 131 forks source link

wrong file size/time for large files #52

Closed simsong closed 11 years ago

simsong commented 11 years ago

Converted from SourceForge issue 2112139, submitted by nobody

Hi,

I use md5deep precompiled binaries on windows 2003 x86. when I run on large files (e.g. about 3GB), file size is incorrectly displayed as a very big number: I think the program converts 3GB in megabytes, but there's some 32bit integer overflow issue, because I read a number which is very close to 0xFFFFFFF (maybe a cast to signed integer followed by promotion to unsigned? -- all of this is just a blind conjecture, I didn't debug)

note that also remaining time is apparently affected (it shows a huge value... obviously)

-Mycroft

you can contact me at "psion.s5 AT gmail dot com"

simsong commented 11 years ago

Submitted by jessekornblum

The problem may be related to our switch to using the stat information to get the file size. We're currently using _wstat, which returns a 32-bit file size (perhaps signed?). We should be using one of the 64-bit functions in the Win32 API. See http://msdn.microsoft.com/en-us/library/14h5k7ff(VS.80).aspx for details.

simsong commented 11 years ago

Submitted by jessekornblum

A patch for this bug has been checked into SVN and is being tested.