ESC doesn't close the modal.

jessekorzan / expodal

The Most Explosive Modal on The Web.

http://www.explodal.com

378 stars 18 forks source link

ESC doesn't close the modal. #2

Open stolemotion opened 7 years ago

stolemotion commented 7 years ago

As a desktop user I'd expect ESC to close the modal.

jessekorzan commented 7 years ago

That'd be an easy one for someone to tackle with a little JS, if they wanted. Personally, I don't believe it's a common expectation for web apps, but such a low effort addition that I can't see why not. And good test... I'd love to be proven wrong here.

I am also going to start trying ESC on different web apps.

etse commented 6 years ago

Adding ESC to close and sound (from #1) should make it mostly UU-compliant. Making it work for blind people.