search

jessekrubin / pbfont

pbf-font(s)
Other
2 stars 2 forks source link

Add test for #91 #96

Closed acalcutt closed 2 months ago

acalcutt commented 2 months ago

Add test for https://github.com/jessekrubin/pbfont/issues/91 . This test shows the issue I mentioned.

After https://github.com/jessekrubin/pbfont/pull/93 image

Before that commit image

jessekrubin commented 2 months ago

Sick! Looookin good Billy ray.

acalcutt commented 2 months ago

Looking at this more I am still not sure it is making the composite correctly

The old @mapbox/glyph-pbf-composite gave this as a composite 5120-5375.pbf.txt

If i get rid setting the name in the test, the result looks more like that file, except the range is 0-255 instead of 5120-5375. If I make the expected file the old one from glyph-pbf-composite, it seems to show that difference image

jessekrubin commented 2 months ago

I can take a look when I get home. If I had to guess the id range should not be set from the id.