:hammer: fix atom 1.13 deprecation warnings

jesseleite / an-old-hope-syntax-atom

⚛️ Atom theme inspired by a galaxy far far away...

MIT License

86 stars 20 forks source link

:hammer: fix atom 1.13 deprecation warnings #20

Closed cloud-walker closed 7 years ago

cloud-walker commented 7 years ago

I've followed the atom's deprecation cop instructions, and seems to working fine, lemme know!

jesseleite commented 7 years ago

Interesting, I assume this solves issue #19?

Also is Atom going towards something like BEM with those double dashed syntax--selectors, etc.?

cloud-walker commented 7 years ago

yes I think so, there was a blog post about it not so long ago...

BTW I need a review, I'm not an expert about atom plugins

cloud-walker commented 7 years ago

I've found the blog post

http://blog.atom.io/2016/11/14/removing-shadow-dom-boundary-from-text-editor-elements.html

jesseleite commented 7 years ago

Great thanks for info, I'll definitely look into this and review 👌

jesseleite commented 7 years ago

Thanks @cloud-walker for the help! I reverted the work you did in ui-modifications, because those classes aren't supposed to have syntax--. Seems some of those styles don't work in 1.13 though, so I have some research to do. But nice work on the base.less file, thanks again!