search

jesseleite / an-old-hope-syntax-atom

⚛️ Atom theme inspired by a galaxy far far away...
MIT License
86 stars 20 forks source link

JavaScript syntax - this keyword #3

Open kfalkiewicz opened 8 years ago

kfalkiewicz commented 8 years ago

Hi Great work with it, but can you modify JS syntax highlight? "this" isn't highlighted as keyword. Ofc. $this would be same color as variables, but "this" should be red as rest of keywords (like "var"). Nice to have :)

PS: One dark recognize this everywhere, so $this also has red color (not best but still good).

jesseleite commented 8 years ago

Thanks for kind words.

Yeah I intentionally deviated from One Dark. Though this is a keyword, it's just an accessor for current object scope. For example, myObject.method() doesn't colour the object red, but this.method() does. This differs by theme though.

Dayle Rees' schemes were a big inspiration. Dayle doesn't seem to follow any specific standards as to what should be coloured and how. He seems to have a more artistic approach to things. Often his themes are based on very narrow palette (as low as 2 or 3 shades only), and so he's very conservative with what he colours and where.

Ultimately, I think it's subjective to opinion. I'll leave this open to discussion for now. Not sure where I stand :P

MadcapJake commented 8 years ago

You can always add it yourself via the custom stylesheet Atom provides.