.storage.type is overriding coloring for variables

[arahansen]

var and let have the storage and type classes which results in the light-gray color being selected.

The result is essentially no syntax highlighting for these keywords. I found that removing the .storage.type light gray selector results in the desired behavior for me.

I'm not sure if that selector is used elsewhere that I'm not thinking of though.

https://github.com/JesseLeite/an-old-hope-syntax-atom/blob/d8439817d55983843422d22ef59dbb5ca53c076d/styles/base.less#L111

[kfalkiewicz]

Same here. It looks odd.

[jesseleite]

@arahansen @Nosenation: I agree with this one, but changing .storage.type has an unwanted effect in other languages such as PHP. Anyway I checked scope on var and let in Javascript, and believe I fixed by styling .storage.type.var. with this commit.

Enjoy, and thanks for reporting :)

[kfalkiewicz]

@JesseLeite I have last version and problem still is visible when var is in global scope (like in gulpfile.js).

[jesseleite]

@Nosenation I see red as expected in my gulpfile.js:

You even have yellow require calls, which isn't intended. I notice at bottom, the syntax mode in your editor says JavaScript with JSX. I don't have that grammar mode installed. Try switching your grammar mode by opening command palette > Grammar Selector > JavaScript:

Other grammar modes will often do their own thing.

[kfalkiewicz]

Hmm, you are right. My bad. On normal syntax everything is ok :)

[jesseleite]

Awesome :+1: