search

jessepeterson / margarita

Web frontend for reposado
The Unlicense
245 stars 40 forks source link

Bug - if update is active in all branches it can no longer be managed via margarita #23

Closed jelockwood closed 11 years ago

jelockwood commented 11 years ago

While it may not be a configuration that most people might need I have found what I believe to be a bug. If you create two (or more) branches and have the updates enabled in both (i.e. all) branches, then the updates are no longer shown in the Margarita web interface. A scenario might be wanting to created a released branch with most updates enabled, and a test branch with all updates enabled. It would be quicker to create initially the released branch with all updates enabled and then disable those not wanted rather than enabling them all individually.

A workaround for when you get in to this state would either be to use the reposado command line or in margarita add an additional branch with no updates enabled, it will then show the other branches contents again.

I am running margarita under OS X 10.8.3 with flask. Updates have been downloaded to the local reposado repository.

jessepeterson commented 11 years ago

This is intended behavior, actually. If you simply click the "Hide commonly listed updates" button - this behavior is disabled and all updates are displayed at the same time. The idea here is that most of the time you don't want to see the long list of all updates - only the new updates flowing in on periodic reposado sync/updates.

jelockwood commented 11 years ago

I will re-try with that tick box, I may not have allowed enough time for it to redraw and/or misunderstood it.

Thanks.

jessepeterson commented 11 years ago

Which browser are you using? Appears to be working okay in Chrome 25 and 26.

jelockwood commented 11 years ago

I tried the hide commonly listed updated option and it works as you said and revealed the 'missing' updates. I was misunderstanding its purpose and not give it time to redraw the list. Thanks for your response.

jessepeterson commented 11 years ago

No worries. You bring up a good point, though. Perhaps there ought to be a spinner or something to indicate things are loading. On slower machines it does take a bit of a delay.

jelockwood commented 11 years ago

Perhaps another option would be to have a label in the footer saying something like 'Showing x out of y updates'.

jessepeterson commented 9 years ago

Commit 39d50b771dfd6f0cf4251bd621c07a68c7f31478 adds this very table footer, FYI.