jessepeterson / margarita

Web frontend for reposado
The Unlicense
244 stars 40 forks source link

Change request type from POST to GET for /list_branches and /products #8

Closed gregneagle closed 12 years ago

gregneagle commented 12 years ago

When first testing out Margarita, I was watching the log (or actually the stdout output of python margarita.py) and was a bit concerned that my merely opening "http://localhost:8089" resulted in four POST requests.

Usually POST requests mean data is being modified on the server. After looking at the code, I noticed that you are using POST requests to get the list of branches and the list of products. Normally these would be GET operations, since data is being retrieved, and nothing is being changed.

This commit changes the request type of those two operations from POST to GET. Two very small changes to margarita.py and margarita.js.

Thanks for considering this change!

-Greg