search

jessepollak / card

:credit_card: make your credit card form better in one line of code
MIT License
11.66k stars 1.48k forks source link

Add additional card types #18

Closed rozbb closed 9 years ago

rozbb commented 10 years ago

I'm not sure how many cards this affects, but here's an example:

Type in 62 into the card entry. It should be UnionPay. It's nothing. Try 622. It should be Discover. Nothing.

Furthermore, 622 is not a Discover card prefix, it's a UnionPay prefix. The program is missing a few card numbers as well.

See: the Wikipedia page

Smashman commented 10 years ago

The demo clearly says that it only supports designs for Mastercard, Visa, Discover, and American Express. So this is not necessarily an issue, just not finished as-yet.

jessepollak commented 10 years ago

Definitely something I want to do, just requires a lot more designing. If you want to give any of the cards a go, I'd love to merge a PR.

mrextreme commented 10 years ago

Here are some test card numbers. Laser is/was an Irish card, it's being phased out rapidly, using it online was always near-impossible. Delta became Visa. Solo is no more since 2011. Switch became Maestro (MasterCard). Some of these older card types CANNOT be determined just by looking at the card number ( see Solo vs. Laser ), they are obsolete - so is their support.

Visa
    4263971921001307
    4000126842489127
    4000136842489878
    4000166842489115
    4009837983422344

Mastercard
    5425232820001308
    5114617896541284
    5114634523652350
    5121229875643585
    5135024345352238

Laser
    6304939304310009610
    6304908620589523057
    6304936989767381455
    6304902235219564797
    6304902507676842597

Switch
    6331101999990073
    490303400005710388

AMEX
    374101012180018
    375425435431
    375425435431347
    343452345245640
    372349658273959

Delta
    4544321006384999

Diners
    36256052780018
    36256052800014
    36256052790017
    38865030565503
    30450000000001

Solo
    633478111298873700
    633478254819816400
    633478219790925900
    633478809869242300
    633478384467574900
    633478033217574500
    633478955263546000

4242424242424242    Visa
4012888888881881    Visa
4000056655665556    Visa (debit card)
5555555555554444    MasterCard
5105105105105100    MasterCard
5200828282828210    MasterCard (debit card)
378282246310005         American Express
371449635398431         American Express
6011111111111117    Discover
6011000990139424    Discover
30569309025904          Diners Club
38520000023237          Diners Club
3530111333300000    JCB
3566002020360505    JCB
Smashman commented 10 years ago

The support already exists, it's merely the designs that do not.