search

jessepollak / card

:credit_card: make your credit card form better in one line of code
MIT License
11.66k stars 1.48k forks source link

Card brand "elo" no detected #200

Closed reginaldojunior closed 8 years ago

reginaldojunior commented 9 years ago

The card of brand "elo" no is detected.

Examples of numbers this card find in https://gist.github.com/erikhenrique/5931368

darlanmendonca commented 9 years ago

Some intend to add support for brand "elo"?

Fivell commented 9 years ago

this can help to add support for ELO brand https://github.com/Fivell/credit_card_validations/commit/7ee9a809c5682760a363a334109846e3d5a0c37a

evansantos commented 9 years ago

@darlanmendonca @reginaldojunior i think that would be nice if you could implement this, @jessepollak would be glad =D

darlanmendonca commented 9 years ago

right, I will make a pull request following logic and structure of @jessepollak with:

reginaldojunior commented 9 years ago

:+1:

When possible create a pull request'm kind of out of time now.

evansantos commented 9 years ago

GREAT, SCOTT!!!

@darlanmendonca you had to modify this little buddy here https://github.com/jessepollak/payment/blob/master/src/payment.coffee

reginaldojunior commented 8 years ago

Guys i am try add this brand, but I don't know where in files scss to compile automatic.

Help me please!

reginaldojunior commented 8 years ago

Done!

:smile:

evansantos commented 8 years ago

awesome @reginaldojunior... did you added your regex to payment.coffee?

reginaldojunior commented 8 years ago

@evansantos The units tests did stay wrong I am try to fix. :bug:

jessepollak commented 8 years ago

Will be fixed in v1.2.0!