jessepollak / card

:credit_card: make your credit card form better in one line of code
MIT License
11.66k stars 1.48k forks source link

Please Add JCB,Diners and UnionPay #99

Closed ftkro closed 10 years ago

ftkro commented 10 years ago

Because asia region Most used brand. or already available? (I'm sorry, because it is Japanese, English is not well written.)

JCB Logo:http://partner.jcb.jp/brand/images/logo_img01.jpg Diners Logo: https://www.diners.co.jp/ja/img/merchant/download/diners_logo_black.gif

ftkro commented 10 years ago

JCB Card number ranger (First few digits): 3528~3589 Diners Card number ranger (First few digits): 300-305, 3095, 36, 38-39 UnionPay Card number ranger (First few digits): 622126-622925, 624-626, 6282-6288 UnionPay Logo: http://shanghai-portal.com/wp-content/uploads/unionpay.jpg

ghost commented 10 years ago

:+1: will do it in the coming week if nobody does.

jessepollak commented 10 years ago

Happy to accept a PR with these cards added — note that you'll have to implement the actual card faces and logos in CSS, no images allowed :)

ftkro commented 10 years ago

OK, I'll try to create these logo CSS. (But maybe too difficult)

ftkro commented 10 years ago

I create JCB logos. But not tested(Because SCSS compile error) Please Download(ZIP file,Expire 2014/08/12 -yy/mm/dd): https://data.jre655.com/public.php?service=files&t=e60fb5b0a97665b512a494963ce1b71c

jessepollak commented 10 years ago

Please open up a Pull Request to the repo with the changes — any SCSS compile errors will need to be fixed, otherwise there will be no CSS :/

ftkro commented 10 years ago

OK, I'll open up Pull Request.

jessepollak commented 10 years ago

Thanks!

On Tue, Jul 29, 2014 at 7:55 PM, Fukuda Takuro notifications@github.com wrote:

OK, I'll open up Pull Request.

— Reply to this email directly or view it on GitHub https://github.com/jessepollak/card/issues/99#issuecomment-50567996.

ftkro commented 10 years ago

Here! https://github.com/jessepollak/card/pull/100

yazinsai commented 10 years ago

By the way, the regex rule for detecting JCB is:

^(?:2131|1800|35\d{3})\d{11}$

JCB cards beginning with 2131 or 1800 have 15 digits. JCB cards beginning with 35 have 16 digits.

Source: http://www.regular-expressions.info/creditcard.html

ftkro commented 10 years ago

Thanks.

kimchakabuto commented 5 years ago

1000