jessepollak / command

:black_nib: Making the web better with Slack-like slash commands.
http://slashcommand.club
MIT License
1.11k stars 66 forks source link

Google hangouts is unsupported #30

Open JSFernandes opened 8 years ago

JSFernandes commented 8 years ago

Hello and thanks for the fantastic extension,

After toying around with it in a bunch of places I have found that it does not work with Google hangouts. Here is an example of the DOM element where text is edited in GH: <div id=":8g.f" class="vE dQ editable" aria-label=" Text entry field for [redacted]. History is on. " g_editable="true" role="textbox" contenteditable="true" dir="ltr" style="text-align: left;"></div>

I might give this a look during the weekend, but I'm creating an issue for reference purposes.

jessepollak commented 8 years ago

Thanks for this report — I really appreciate it! I've added Google Hangouts to the wiki here.

If you want to take a look this weekend, I'd be happy to provide backup :D

JSFernandes commented 8 years ago

Like I said, I started taking a look into this today. I figured out that the hangouts input is inside an iframe, such as this one:

<iframe src="https://hangouts.google.com/webchat/u/1/frame?v=[redacted]" frameborder="0" scrolling="no" class="a7A" width="262" height="379"></iframe>

Since this iframe points to hangouts.google.com, I think this makes it impossible to interact with the input from mail.google.com, due to CORS issues.

If I go to hangouts.google.com, I also get a similar iframe, but one whose DOM I can actually interact with, seeing as there are no CORS issues.

I'm now gonna look into ContentEditable.js and the the contenteditable standard. If you've got any good links to explain those, I'd greatly appreciate it.

jessepollak commented 8 years ago

Awesome, good research! I don't have any really great resources on contenteditable, but I'm happy to answer any questions you have may about ContentEditable.js!

bgiesing commented 8 years ago

@jessepollak @JSFernandes Here's some links with dev info and things you can do with it: https://developer.mozilla.org/en-US/docs/Web/Guide/HTML/Content_Editable http://www.w3schools.com/tags/att_global_contenteditable.asp https://medium.com/medium-eng/why-contenteditable-is-terrible-122d8a40e480 http://lifehacker.com/5980134/turn-any-browser-window-into-a-quick-edit-notepad http://www.labnol.org/internet/design/edit-web-pages-like-wiki/3832/

livejamie commented 5 years ago

It's a long shot but I wanted to bump this