add bitly command - Githubissues

jessepollak / command

:black_nib: Making the web better with Slack-like slash commands.

http://slashcommand.club

MIT License

1.11k stars 66 forks source link

add bitly command #48

Open sharmasha2nk opened 8 years ago

sharmasha2nk commented 8 years ago

Support to add validations in Search Widget
Using isResultList to change height of result container
Update limit to 6 from 5
Bitly api support
Added valid-url dependency to validate URL

jessepollak commented 8 years ago

Thank you so much for this PR — I love the idea of adding bit.ly support to Command! Super excited to get this merged in.

My primary concern is that I don't think Search is the most intuitive for this experience. I'd rather have an experience where a user entered a link and then clicked a "Shorten" button, which then triggered the shortened link to be spit out.

What do you think about that? Would you be up for refactoring along those lines?

Again — really excited to get this merged in!

sharmasha2nk commented 8 years ago

Glad you liked the idea. 😀

I was also thinking about adding another component with button. But I later go ahead adding validations in search which will hold making any network call until a valid link is entered. I think usually if people are using bitly to shorten link they will be copying the link instead of typing. And adding button after that will just increase the clicks.

I know there is one issue right now that if someone start typing the link to shorten, it will make the shorten link once it found a valid URL even though he didn't finished typing URL 😰. I'll fix that issue in next commit. May be we can have something similar like Bitly site is having. If link is pasted will shorten it then and there otherwise user hits enter or button to shorten it.

Current UX: 2lqdw31jw5

Let me know your views. Thanks.

P.S I have also posted an article about your extension medium/sharmasha2nk/command

jessepollak commented 8 years ago

I like the solution of automatically shortening on paste but requiring a button press when the user types out the link. If you switch to using that UX, we can merge this in!

albinekb commented 8 years ago

maybe /bitly [url] then shorten when the user presses enter?

sharmasha2nk commented 8 years ago

Hi @jessepollak how about this UX: ubcxkzyxr3

jessepollak commented 8 years ago

@sharmasha2nk yes, that looks awesome - is that in the current PR?

sharmasha2nk commented 8 years ago

@jessepollak Not yet in PR as I'm planning to add options page also so user can configure his own bitly account. Would be great if you could help to solve #51