search

jessepollak / payment

:moneybag: A jQuery-free general purpose library for building credit card forms, validating inputs and formatting numbers.
MIT License
563 stars 157 forks source link

Wrong mastercard pattern #214

Open GDMeira opened 1 month ago

GDMeira commented 1 month ago

The mastercard pattern should be /^(5[1-5]|677189)|^(22[2-9][1-9]|2[3-6]\d{2}|27[0-1]\d|2720)/ A card number starting with 223 is not passing the test, but it should pass.

melloware commented 1 month ago

Thanks for reporting this.

GDMeira commented 1 month ago

Thank you for this response. I was looking at PR's, and it looks like no one, since 2021, is passing trugh "travis-ci". Do you think that this PR will be merged?

melloware commented 1 month ago

@jessepollak is in charge of that CI. I can only merge if the CI is passing and it looks dead. So we need @jessepollak to disable the strict PR checks here to allow me to merge and then I can cut a new release.

I can cut a new release to NPM without this PR being merged it just feels wrong but you are right what other choice is there.

GDMeira commented 1 month ago

@jessepollak could you please help me with this issue?

melloware commented 1 month ago

i published 2.4.7 in NPM

GDMeira commented 1 month ago

Thank you very much for your help!