jesserizzo / envoy_reader

MIT License
37 stars 26 forks source link

Fix support for Envoy 'P' models that do not have consumption capabilities #15

Closed dennisdegreef closed 4 years ago

dennisdegreef commented 4 years ago

Due to the asynchronous nature of this code, whenever a consumption call is made, and the model is not yet known from a 'production' call, the message_consumption_not_available is not returned, because the model is still an empty string.

This is in the case where the Envoy model does not support 'consumption'.

This merge request should fix these cases by also doing a model detection on the consumption calls.

I'll link an issue I am drafting from another project that is using this library as a plugin with a more detailed report.

Let me know what you think :)