Rename master to main - Githubissues

jesserizzo / envoy_reader

MIT License

37 stars 26 forks source link

Rename master to main #66

Closed jesserizzo closed 3 years ago

jesserizzo commented 3 years ago

Pull request recommendations:

[ ] Name your pull request your-development-type/short-description. Ex: feature/read-tiff-files
[ ] Link to any relevant issue in the PR description. Ex: Resolves [gh-12], adds tiff file format support
[ ] Provide context of changes.
[ ] Provide relevant tests for your feature or bug fix.
[ ] Provide or update documentation for any feature added by your pull request.

Thanks for contributing!

jesserizzo commented 3 years ago

@gtdiehl Any idea why some of these workflows were already triggered from 'main'?

gtdiehl commented 3 years ago

@jesserizzo I don't know maybe some timing issue? It appears everything is passing after changing the test/workflow

jesserizzo commented 3 years ago

@bdraco It looks like you just added build-docs and build-main a few days ago. Both triggered off of main even though the default branch at that time was named master. Now after the name change, build-main succeeds, but build-docs fails. Any thoughts?

gtdiehl commented 3 years ago

@jesserizzo I've disabled the Documentation workflow for now. I thought this was a builtin app/tool from Github, but I think we need an extra Makefile to utilize the gen-docs target

bdraco commented 3 years ago

@bdraco It looks like you just added build-docs and build-main a few days ago. Both triggered off of main even though the default branch at that time was named master. Now after the name change, build-main succeeds, but build-docs fails. Any thoughts?

It's a generic workflow template that assumes there are docs.

Probably best to just disable it until their are. 👍