Improvements for the "cheque" system

[GoogleCodeExporter]

My suggestion is:
1. Make players able to use /check as in addition to /cheque, as many people 
(including me) know the word by that spelling.
2. Make it so the money isn't taken away from the player until the check is 
cashed (used) like in real life.
3. Make it so somebody other than the person it's written to can destroy the 
check (tear it up) by pressing E on it, but only when it's not being held with 
the gravity gun. Maybe it can take a second or two to prevent abuse.

Why this should be in DarkRP by default and not a third party addon:
It would make a feature that's already in DarkRP more realistic. Also, 
currently you can't cash a check that you wrote unless it's made out to you as 
well, so if you make a typo in the amount (like an extra 0) you're stuck with 
it.

Note: If this is a scoreboard suggestion, post in issue 276
It's not.

Original issue reported on code.google.com by flarn2...@gmail.com on 16 Jan 2011 at 8:47

[GoogleCodeExporter]

All added here: http://code.google.com/p/opendarkrp/source/detail?r=79

Also Falco, can you add Drakehawke: to the log message if/when you apply it 
here, I forgot, sorry.

Original comment by ch...@watersideway.plus.com on 17 Jan 2011 at 12:01

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

I simply can not allow cheques to not take the money away until it's used. Why:
This exploit would be created
Starting money: 500$
/cheque otherplayer 500
*other player doesn't pick up cheque*
/dropmoney 500
*other player picks up cheque*

You would have debts. You're fucked in DarkRP if you have a debt. Debts have 
fucked up DarkRP before with such exploits (back before DarkRP 2.3.1).

Original comment by fpeijnen...@gmail.com on 17 Jan 2011 at 10:55

[GoogleCodeExporter]

also what would anyone else's reason be to tear a cheque up, rather than just 
fucking about?

Original comment by fpeijnen...@gmail.com on 17 Jan 2011 at 10:58

[GoogleCodeExporter]

Make it become a hot check, say I have 499, and I wrote it for 500, it says 
something about hot check and doesn't work.

Idk, i never used the cheque system.

Original comment by wr.jr199...@gmail.com on 17 Jan 2011 at 6:38

[GoogleCodeExporter]

No, that would still allow exploits.

I will add /check and tearing up your OWN cheque.

The rest of the request shouldn't be in DarkRP due to exploit sensitivity and 
an increased chance of minging.

Original comment by fpeijnen...@gmail.com on 18 Jan 2011 at 10:12

• Changed state: WontFix

[GoogleCodeExporter]

I thought of that Falco, if you look in my commit I added a owned money thing 
to the players table and it checks it in the player.CanAfford function, so it 
works fine.

Original comment by ch...@watersideway.plus.com on 18 Jan 2011 at 4:56

[GoogleCodeExporter]

*owed, not owned

Original comment by ch...@watersideway.plus.com on 18 Jan 2011 at 5:01

[GoogleCodeExporter]

But with that system people this happens:
Starting amount: 500
/cheque player 450
Doesn't get picked up
/buyshipment m4
*You don't have enough money*
"But dude I have like 500, that should be enough! wtf!"

It will cause confusion.

Original comment by fpeijnen...@gmail.com on 18 Jan 2011 at 5:49