search

jesserockz / python-juicenet

MIT License
12 stars 10 forks source link

Allow override Time of Use #1

Closed jesserockz closed 5 years ago

jesserockz commented 7 years ago
LorenKeagle commented 5 years ago

Hey there, @jesserockz

Are you still maintaining this library? It appears to be used by the juicebox module in HomeAssistant, and I would very much like to be able to trigger the charge override function from an automation script.

I know the API that should be called to set the override flag. I'm just wondering if I should fork your project or whether you're interested in completing this enhancement.

jesserockz commented 5 years ago

Hi @LorenKeagle.

As you can see I have always wanted to create it but just never had the time/forgot about doing it. If your happy to implement it then im happy to accept a PR with the changes and release it.

LorenKeagle commented 5 years ago

Seems straightforward enough. I'm not a python guy, but this should be fairly easy.

LorenKeagle commented 5 years ago

Hey @jesserockz,

I've submitted a PR for adding support for setOverride. If there's any other functionality you think might be useful, I'm happy to continue to work on it. Otherwise, if we can get this PR merged I will work on getting support added downstream in the HomeAssistant project.

My end goal is to be able to automatically enable my charger during the day when I know I have the additional solar capacity to handle it. I don't want to dip into the grid if it gets cloudy or my A/C turns on :-)

jesserockz commented 5 years ago

Thanks for that @LorenKeagle Do you have a link the the documentation for the API?

jesserockz commented 5 years ago

@LorenKeagle I have release 0.1.0 to PyPi 🎉