search

jessesquires / BButton

Twitter Bootstrap buttons for iOS
http://cocoadocs.org/docsets/BButton/
Other
712 stars 82 forks source link

NS_ENUM Swift compatibility #33

Closed chrisballinger closed 9 years ago

chrisballinger commented 9 years ago

The current layout for the NS_ENUM doesn't match the guidelines where they are all prefaced with FAIcon, so certain types like "FATimes" can't be chosen.

jessesquires commented 9 years ago

Thanks @chrisballinger !

lucasiturbide commented 9 years ago

@jessesquires how do you want to manage this issue? I will have to change the name convention for the Icons. Is that OK? Regarding the Swift guidelines, instead FATimes should be FAIconTimes, right?

chrisballinger commented 9 years ago

Ya, it will break compatibility.. so maybe a major version bump?

jessesquires commented 9 years ago

@lucasiturbide @chrisballinger - yep!

This issue is marked for the 5.0 milestone.

lucasiturbide commented 9 years ago

So changing the name convention to FAIconTimes (instead of FATimes, and so on... ) is the right path ? Sorry, I'm not familiar with Swift and I don't want to break anything :)

jessesquires commented 9 years ago

@lucasiturbide - That's right, basically, everything should be prefixed with FAIcon instead of only FA