search

jessesquires / JSQMessagesViewController

An elegant messages UI library for iOS
https://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Other
11.14k stars 2.81k forks source link

Container views and custom chat cells #556

Closed jfyles closed 10 years ago

jfyles commented 10 years ago

Hi Jesse,

We've been using your JSQMessagesViewController for our product, Cast, and it's really been working well for us. We have integrated your latest beta of 6.0 into our app. We appreciate the hard work you've put into it, and we're hoping you could answer a few questions for us.

Firstly, let me start of by saying how we use your view controller in our app. It's inside a container view inside a view controller of our own creation, which is in turn inside a UINavigationController. This is because we display a highly customized, variable-height toolbar at the top, as shown in the attached screenshot. Is that an issue, and could it be the cause of our keyboard issue below?

We would like to display several types of messages in our chat that aren't just "chat" messages -- they may include extra info derived from the text of the previous message, or they might be system messages that aren't sent from anyone (these shouldn't have an avatar) and may include complex content such as buttons. We attempted simply returning a custom cell from collectionView:cellForItemAtIndexPath:, but that doesn't seem to do the job, as all the cell types get jumbled when we scroll (messages displaying with the wrong cell type), and also the cell is strangely sized. Is there a way to create fully custom chat cells?

We're also seeing a bug that seems to be exactly #118, but that was fixed in 5.0. Has this bug resurfaced in 6.0? It's much more likely we're doing something wrong, and we'd appreciate any insight you can provide, as we have no clue what could be wrong here, since your code appears to completely handle this in JSQMessagesKeyboardController.

Thank you very much for your help, and thanks for the great library (donation sent)!

ios simulator screen shot oct 10 2014 1 51 12 pm

jessesquires commented 10 years ago

Thanks @jfyles !

  1. Regarding a custom header and animating the toolbar: see #311, #287, #477 (I suspect your issue with #118 is because of this header)
  2. System messages, see: #321. This is not yet implemented and will require some additional work. You'll probably need to maintain your own fork to do this for now. PRs are always welcome!

Hope this helps!

jfyles commented 10 years ago

Amazing as always. Thanks!

Justin

jessesquires commented 10 years ago

No problem!

Closing as resolved. Re-open if needed.