search

jessesquires / JSQMessagesViewController

An elegant messages UI library for iOS
https://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Other
11.14k stars 2.81k forks source link

Bubble images don't show up when building in release mode #583

Closed jfyles closed 10 years ago

jfyles commented 10 years ago

Bubble images stopped showing up as of -beta6 when building in release mode. I worked around it by adding a "bubble_min" to our xcassets and dragging the bubble assets in there, but I don't think that's the right solution.

jessesquires commented 10 years ago

Thanks @jfyles .

The pod spec validates and a small test project that I setup seems to be working fine.

Is there anything non-standard in your podfile or project setup?

Can you see the resources copied in the pods project?

jfyles commented 10 years ago

Hey Jesse,

I don't think there is anything nonstandard, but I am a bit of a noob. The build phase for copying resources is there (from "${SRCROOT}/Pods/Target Support Files/Pods/Pods-resources.sh" ) in our build phases.

Should there be a build phase for copying bundle resources in the pod build phases?

jessesquires commented 10 years ago

Maybe something got messed up the last time you ran pod update.

I would try:

  1. make sure you have the latest cocoapods installed
  2. delete the pods/ directory and generated .xcworkspace
  3. run a fresh pod install
jfyles commented 10 years ago

Just tried that -- no dice. I am fine with including the image asset for now, as we might end up changing the bubble shape anyhow. I don't feel like I've done anything out of the ordinary though, so i'm surprised I am the only one seeing this!

jessesquires commented 10 years ago

Hey @jfyles - I just setup a test project and included the pod. I built for debug and release and didn't see any issues. Since no one else has reported this, I'm inclined to think the issue is on your end...

Can you try setting up a completely fresh project and see if you can reproduce? Maybe upload a repo so I can see...?

jessesquires commented 10 years ago

Hey @jfyles - any updates?

I'm going to go ahead and close this as no one else appears to be having this issue (and I can't reproduce).

I would recommend getting the latest from develop:

pod 'JSQMessagesViewController', :git => 'https://github.com/jessesquires/JSQMessagesViewController.git', :branch => 'develop'

There are new category methods on UIImage now for each of the message bubble assets.

It might be worth seeing what these methods return after you get the latest.

https://github.com/jessesquires/JSQMessagesViewController/blob/develop/JSQMessagesViewController/Categories/UIImage%2BJSQMessages.h