search

jessesquires / JSQMessagesViewController

An elegant messages UI library for iOS
https://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Other
11.14k stars 2.82k forks source link

Display Text *and* Media #681

Closed knitterb-razzle closed 7 years ago

knitterb-razzle commented 9 years ago

I really like this control, thank you! One thing I can't figure out is how to include text AND a media item (video, photo) at the same time? It appears this is one or the other? Many messaging systems (MMS, Hangouts, WhatsApp) now allow for text to accompany the media message. Is this possible? If not, can I request that this is added?

jessesquires commented 9 years ago

Thanks @knitterb-razzle !

Yes, currently you must send text messages and media messages separately. The 6.0 release was the first release to add media messages, so the library is just getting started with regard to this feature.

... allow for text to accompany the media message.

By this, do you mean in the text view where you compose a message, that you can display attachments in-line with the text? And/or that the text and attachment are displayed in the same message bubble once sent? For example, iOS Messages allows you to combine text and photos in the input text view, but displays them as separate bubbles.

knitterb-razzle commented 9 years ago

Right on!! Love the library, so definitely not calling you our or telling you it's a horribly missing feature. Would be an awesome new feature.

Specifically, I'm looking to be able to click on the attachment icon, attach a picture and then send text with it. While it might be neat to see the image right in the text box, this seems a little busy for a mobile interface. But definitely the text next to the image.

Let me know if I can provide more details or a screenshot.

Brandon Knitter VP Engineering Razzle brandon@razzle.mobi c: 650-285-3197

530 Lytton Ave, 2nd Floor Palo Alto, CA 94301

On Mon, Dec 15, 2014 at 1:41 PM, Jesse Squires notifications@github.com wrote:

Thanks @knitterb-razzle https://github.com/knitterb-razzle !

Yes, currently you must send text messages and media messages separately. The 6.0 release was the first release to add media messages, so the library is just getting started with regard to this feature.

... allow for text to accompany the media message.

By this, do you mean in the text view where you compose a message, that you can display attachments in-line with the text? And/or that the text and attachment are displayed in the same message bubble once sent? For example, iOS Messages allows you to combine text and photos in the input text view, but displays them as separate bubbles.

— Reply to this email directly or view it on GitHub https://github.com/jessesquires/JSQMessagesViewController/issues/681#issuecomment-67071146 .

jessesquires commented 9 years ago

@knitterb-razzle - mock up of what you're interested in would be great!

knitterb-razzle commented 9 years ago

This is from hangouts. On Dec 15, 2014 4:30 PM, "Jesse Squires" notifications@github.com wrote:

@knitterb-razzle https://github.com/knitterb-razzle - mock up of what you're interested in would be great!

— Reply to this email directly or view it on GitHub https://github.com/jessesquires/JSQMessagesViewController/issues/681#issuecomment-67093100 .

jessesquires commented 9 years ago

@knitterb-razzle - i think you forgot the attachment

knitterb-razzle commented 9 years ago

img_20141215_164742

knitterb-razzle commented 9 years ago

Sorry! Email replies don't seem to take attachments. Let me know if this makes sense. If not I can annotate it, a picture is worth a thousand words.

felipericieri commented 9 years ago

Hi! First of all, thanks (too) for this amazing library! I think i got the same need. I need to show text and media together (just like whatsApp do). I saw this is possible using JSQMessageMediaData protocol, but I need also resize my textView height to its content size and the method "mediaView" (which returns the UIView to display on UICollectionViewCell) is called after "mediaViewDisplaySize" (which returns its CGSize). So, after the UIView actually exists, I setted its width and height. How can I handle this? Thank you again!

felipericieri commented 9 years ago

Hmmm.. I see! So, we have to show the content in separated bubbles. Ok! Thanks!

knitterb-razzle commented 9 years ago

That's what we had to do too, separate bubbles for now. Not the worst thing in the world, but does make the logic for displaying messages a little challenging. I'm hoping to get a chance in a month or two to create a patch (pull request) with this functionality built in. Struggling to find the time! :(

avently commented 9 years ago

We are awaiting your PR:)

mverderese commented 9 years ago

I was just going to +1 this, but after looking through the documentation, it seems like it's pretty easy to achieve this effect by implementing the mediaView and mediaPlaceholderView method in JSQMessageMediaData. I guess the pull request would just have to include an out-of-the-box wrapper for these methods to combine the message and image into one UIView

gmansata6290 commented 7 years ago

@mverderese have you implemented Img and text in the same bubble? if yes then can you just guide me how to resize the bubble as per the content size of the textview? and what if I just want the text and a button instead of Img and text resp. ?

jessesquires commented 7 years ago

Hello everyone!

I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:

http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/

Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊

Thanks for understanding, — jsq