search

jessesquires / JSQSystemSoundPlayer

A fancy Obj-C wrapper for Cocoa System Sound Services
https://jessesquires.github.io/JSQSystemSoundPlayer/
Other
581 stars 107 forks source link

OS X support #11

Closed rodionovd closed 9 years ago

rodionovd commented 9 years ago

Should close #10.

What needs to be done:

I'm also not sure about tests: do we need them to run inside a Mac target as well?

jessesquires commented 9 years ago

thanks @rodionovd ! let me know when it's ready to review

rodionovd commented 9 years ago

@jessesquires well, I think it's ready. The only thing I'm not really sure about is tests: should I create a new target for running tests on OS X?

jessesquires commented 9 years ago

:+1:

  1. I just created a new branch, osx_support. Let's update the PR to merge there instead of develop.
  2. Formatting looks off (could be GitHub?). Should be using spaces, not tabs. Width 4. Should do a cmd-a, ctrl-i
jessesquires commented 9 years ago

thanks @rodionovd !