jessesquires / JSQSystemSoundPlayer

A fancy Obj-C wrapper for Cocoa System Sound Services
https://jessesquires.github.io/JSQSystemSoundPlayer/
Other
581 stars 107 forks source link

Play system soundIDs directly #31

Closed djiangnz closed 8 years ago

djiangnz commented 8 years ago

First step in completing #30

codecov-io commented 8 years ago

Current coverage is 89.64%

Merging #31 into develop will increase coverage by +3.32% as of 3909a39

@@            develop     #31   diff @@
=======================================
  Files             3       3       
  Stmts           424     454    +30
  Branches          0       0       
  Methods           0       0       
=======================================
+ Hit             366     407    +41
  Partial           0       0       
+ Missed           58      47    -11

Review entire Coverage Diff as of 3909a39

Powered by Codecov. Updated on successful CI builds.

jessesquires commented 8 years ago

Thanks for working on this @lastObject ! :smile:

Looks good! :+1: I've left a few comments to address, then I'm happy to merge!

Also, could you squash your commits into 1?

djiangnz commented 8 years ago

@jessesquires thanks for your fantastic work, just too newbie to git try to finish it on weekend,

jessesquires commented 8 years ago

@lastObject - no worries! :smile: there's no rush. let me know if you need any help

djiangnz commented 8 years ago

hi @jessesquires, review my pr plz. let me know if needs any change. cheers

jessesquires commented 8 years ago

nice! thanks @lastObject 😄

jessesquires commented 8 years ago

✨ ping ✨ @lastObject 😄

djiangnz commented 8 years ago

simulator screen shot apr 22 2016 9 19 07 am

this is new page looks like

jessesquires commented 8 years ago

Thanks @lastObject ! 👍

I think we're good to go. I'll merge this soon! 🎉