search

jessetane / queue

Asynchronous function queue with adjustable concurrency
MIT License
762 stars 66 forks source link

POC for job-specific timeouts #60

Closed joelgriffith closed 5 years ago

joelgriffith commented 5 years ago

Test file shows how this works for consumers. Feels a bit left-handed, but seems to be the only way to apply job-specific data without creating huge breaking changes. Let me know what you think!

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 81243527635c5a6cb54b1840cea4788be7ed771a on joelgriffith:job-timeouts into 244cb2f8c09be96c103e4557b58066694d8a6aea on jessetane:master.

jessetane commented 5 years ago

Cool, minimally invasive, works for me.

jessetane commented 5 years ago

@joelgriffith if you have time can you send another patch to add docs for the new features?

joelgriffith commented 5 years ago

Yup, I’ll update docs here soon. When do you typically release new code additions?

jessetane commented 5 years ago

unless you have more you want to add i think we can cut 6.0 as soon we have docs.

we're not breaking the api but better to be safe i think in case for ex someone is already sticking a timeout property on their jobs..