search

jessetane / queue

Asynchronous function queue with adjustable concurrency
MIT License
764 stars 66 forks source link

Refactoring to modern JS + ESM, tests rewritten on tap-esm, removed deps #91

Closed MaksimLavrenyuk closed 1 year ago

jessetane commented 1 year ago

Alright, nice work! Next PR maybe can focus on switching events dep to EventTarget?

jessetane commented 1 year ago

Also for future PRs can you work on feature branches rather than master? The history will make more sense, you can work on more than one thing at a time, rebase if master moves out from under you, etc. e.g. https://docs.github.com/en/get-started/quickstart/github-flow

MaksimLavrenyuk commented 1 year ago

@jessetane

Yes, the next PR focus is on EventTarget.

I apologize for the branch/commit confusion in the previous PR. This is my first PR on github. I don't want to make excuses, but it was a surprise to me that on github you can't change a branch after creating a PR (I mostly use gitlab, it has such functionality). Since I originally linked to master and there were references to it in the issue with discussion, I was afraid to create a new PR. Which, in the end, I still had to do.