search

jessetane / queue

Asynchronous function queue with adjustable concurrency
MIT License
762 stars 66 forks source link

Detaching from events dependency, switching to using EventTarget #92

Closed MaksimLavrenyuk closed 1 year ago

jessetane commented 1 year ago

thanks. so this is where i would use git rebase -i to squash these new commits with their earlier counterparts so the history stays clean. not trying to be annoying but i think most open source projects will expect this in the PR feedback / iteration process. if it's too much hassle though i can live with it as is

jessetane commented 1 year ago

haven't read this but it came up with a quick search, maybe helpful: https://thoughtbot.com/blog/git-interactive-rebase-squash-amend-rewriting-history#interactive-rebase

MaksimLavrenyuk commented 1 year ago

Thanks for the tip! Yeah, I'll do it https://github.com/jessetane/queue/pull/92#issuecomment-1428520093, it's time for me to figure it out.

jessetane commented 1 year ago

note that when you alter history you'll have to force push to your branch, but this is normal

MaksimLavrenyuk commented 1 year ago

@jessetane

Check this

jessetane commented 1 year ago

what's next?

MaksimLavrenyuk commented 1 year ago

We need to switch to Promise instead of callback. After that I would like to add a d.ts file to support projects that use typescript.

jessetane commented 1 year ago

sounds good, let's tackle those in separate PR's. ideally we can continue to support promises and callbacks, but maybe take into account concerns raised in #85 and #34?

MaksimLavrenyuk commented 1 year ago

@jessetane

I apologize for the delay, my main work takes a lot of time.

For issue https://github.com/jessetane/queue/issues/34, I created a PR. For issue https://github.com/jessetane/queue/issues/85, there are questions that need to be discussed. I will write to the issue itself.