search

jesseward / discogstagger

Console based audio-file metadata tagger that uses the Discogs.com API v2 (JSON based). Relies on the Mutagen and discogs-client libraries. Currently supports FLAC and MP3 file types.
MIT License
70 stars 13 forks source link

TypeError: get() takes exactly 1 argument (3 given) #1

Closed cmaussan closed 12 years ago

cmaussan commented 12 years ago

Hi,

First of all, I'm not a power user of python. I try to run your script with python 2.7.2, mutagen 1.20 and requests 0.10.1 and I have this error :

Traceback (most recent call last): File "./discogs_tagger.py", line 488, in logging.info("Tagging album '%s - %s'" % (release.artist, release.title)) File "./discogs_tagger.py", line 140, in artist artist = self.release.artists[0] File "/home/cmaussan/code/ext/discogstagger/discogs_client.py", line 141, in artists self._artists = [Artist(a['name']) for a in self.data.get('artists', [])] File "/home/cmaussan/code/ext/discogstagger/discogs_client.py", line 52, in data if self._response.content and self._response.status_code == 200: File "/home/cmaussan/code/ext/discogstagger/discogs_client.py", line 38, in _response self._cached_response = requests.get(self._uri, self._params, self._headers) TypeError: get() takes exactly 1 argument (3 given)

Do you know how to solve this ?

Thanx,

Camille.

jesseward commented 12 years ago

Hey Camille,

Thanks for reporting this. Would you mind passing along the discogs release id that is causing this error?

I would like to run a local test on my current copy, before checking this back into the repo.

Thanks, Jesse

cmaussan commented 12 years ago

Hi,

Here is the command line I used :

./discogs_tagger.py -r 3341626 -s ~/Téléchargements/Gesaffelstein/Into\ The\ Zone\ -\ Tsugi\ Sampler\ 48/

Camille.

jesseward commented 12 years ago

Hi Camille,

I checked in an updated version, please grab the newest code (or v 0.5). The fixes mainly contains style updates in discogs_tagger.py as well as a sync to latest of discogs_client (now 1.1.1). Notably discogs_client.py contains the logic for the requests module, it does touch the requests.get call .

I ran the tagger against release id 3341626 and requests v10.1 and generated a proper tag.

$ ./discogs_tagger.py -r 3341626 -s ~/Téléchargements/Gesaffelstein/Into\ The\ Zone\ -\ Tsugi\ Sampler\ 48/
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): api.discogs.com
DEBUG:requests.packages.urllib3.connectionpool:"GET /release/3341626 HTTP/1.1" 200 1918
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): api.discogs.com
DEBUG:requests.packages.urllib3.connectionpool:"GET /artist/Gesaffelstein HTTP/1.1" 200 385
INFO:root:Tagging album 'Gesaffelstein - Into The Zone - Tsugi Sampler 48'
INFO:root:Creating destination directory '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48-(TSUGI_48)-2012-jW'
DEBUG:root:Tagging '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48-(TSUGI_48)-2012-jW/01-Hell-Germania.mp3'
DEBUG:root:Tagging '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48-(TSUGI_48)-2012-jW/02-Yoma-Padam.mp3'
DEBUG:root:Tagging '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48-(TSUGI_48)-2012-jW/03-Jonas_Kopp-Cero.mp3'
DEBUG:root:Tagging '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48-(TSUGI_48)-2012-jW/04-Jon_Convex-Order_Into_Chaos.mp3'
DEBUG:root:Tagging '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48-(TSUGI_48)-2012-jW/05-Spank_Rock-DTF_DADT.mp3'
DEBUG:root:Tagging '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48-(TSUGI_48)-2012-jW/06-Franz_and_Shape-Acid_One_(Snuff_Crew_Vocal_Remix).mp3'
DEBUG:root:Tagging '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48-(TSUGI_48)-2012-jW/07-Rob_Threezy-Lets_Go_Ravers.mp3'
DEBUG:root:Tagging '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48-(TSUGI_48)-2012-jW/08-Nina_Kraviz-Ghetto_Kraviz.mp3'
DEBUG:root:Tagging '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48-(TSUGI_48)-2012-jW/09-Detroit_Grand_Pubahs-Club_Sandwiches_(Marc_Romboy_Systematic_Soul_Remix).mp3'
DEBUG:root:Tagging '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48-(TSUGI_48)-2012-jW/10-Torb-Rubidrama.mp3'
INFO:root:Deleting source directory '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/'
INFO:root:Generating .nfo file
DEBUG:root:Writing file '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48-(TSUGI_48)-2012-jW/00-Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48.nfo' to disk
INFO:root:Generating .m3u file
DEBUG:root:Writing file '/home/jward/Téléchargements/Gesaffelstein/Into The Zone - Tsugi Sampler 48/Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48-(TSUGI_48)-2012-jW/00-Gesaffelstein-Into_The_Zone_-_Tsugi_Sampler_48.m3u' to disk
INFO:root:Downloading and storing images
DEBUG:root:Downloading image 'http://api.discogs.com/image/R-3341626-1326557833.jpeg'
DEBUG:root:Downloading image 'http://api.discogs.com/image/R-3341626-1326557845.jpeg'
INFO:root:Tagging complete.
cmaussan commented 12 years ago

Yeah, it works !

I close the issue :)

Thanks a lot,

Camille.