search

jesseward / discogstagger

Console based audio-file metadata tagger that uses the Discogs.com API v2 (JSON based). Relies on the Mutagen and discogs-client libraries. Currently supports FLAC and MP3 file types.
MIT License
70 stars 13 forks source link

Add support for multi disc releases #14

Closed triplem closed 11 years ago

triplem commented 11 years ago

Currently all tracks of one release should be in on directory, on multi disc releases it is quite common to habe each disc in a separate folder. This should be supported as well.

triplem commented 11 years ago

I have read a lot of materials on how multi disc releases should be handled and came to the following conclusion:

There are two distinct methods on handling the multi disc releases: * correctly sort the tracks and show 1 disc which contains all tracks of the multi disc album * show two different discs

Both of the above methods are valid approaches and could be wanted by users. Therefor we need to take this into account. To provide a convinient method to approach this, a flag for such an album should be set, so that discogstagger takes this into account.

For both of these solutions, we should take into account, that the tracks are correctly numbered (the discogs track list has the tracknumbers 1-10, meaning disc 1, track 10). All Tracks should be just stored with a number (meaning in the above example just 10). This does not seem to be difficult to reach. Furthermore the tag discnumber should be stored on the tracks as well, the discnumber can be taken from the tracknumber as well. This does not seem to difficult as well.

This numbering does solve the first solution quite nicely and we can use it in the second solution as well. The "show two different discs" is solved easily via an extension of the disc-title as well. The disc-title should be expanded with a "[disc xx]" extension. This extension could be taken from the tracknumbers as well. Should be easy to solve.

Then there is an even more advanced solution, which can occur, if there are subtitles on the discs (e.g. George Michaels Ladies & Gentleman has titled the first disc "For The Heart", the second one "For The Feet"). Questions is, if we do get this kind of information from the discogs api.

triplem commented 11 years ago

During the determination, if it is a multi disc release, we need to recognize, where all the files are. Like described in my first post, I usually split the files between the discs in separate folders. These are sometimes named equally (cd1, cd2, disc1, disc2, ...) but sometimes not. The only common thing (at least in my workflow) is, that both folders are contained in a folder above with no files (.flac) inside. I guess this could be true for other folders as well (artist-folder e.g.). I think for correct processing, we need to put a file in this folder (if not called manually via command line options) and treat these folders then according to the settings in this file.

I would propose to use the id.txt file, where some properties for the multi disc handling could be stored as well (naming scheme, etc.).

What do you think?

triplem commented 11 years ago

This is already implemented in the latest pull request (will be version 1.2).