search

jesseward / discogstagger

Console based audio-file metadata tagger that uses the Discogs.com API v2 (JSON based). Relies on the Mutagen and discogs-client libraries. Currently supports FLAC and MP3 file types.
MIT License
70 stars 13 forks source link

oauth issue #21

Closed fucheeno closed 10 years ago

fucheeno commented 10 years ago

Hello Jesse,

I absolutely love your app (where do I donate?) but I am having an issue using the oauth addition. This is the error I get. Can you please help me? Thanks!

Traceback (most recent call last): File "/usr/local/bin/discogs_tagger.py", line 204, in get_images(release.album.images, dest_dir_name, images_format, first_image_name) File "/Library/Python/2.7/site-packages/discogstagger/taggerutils.py", line 317, in get_images discogs_auth = DiscogsAuth() File "/Library/Python/2.7/site-packages/discogstagger/discogsauth.py", line 29, in init self._get_request_token() File "/Library/Python/2.7/site-packages/discogstagger/discogsauth.py", line 42, in _get_request_token raise Exception('Invalid response {0}.'.format(rep['status'])) NameError: global name 'rep' is not defined

jesseward commented 10 years ago

Thanks for the report.

Looks like you're on OSX, which version of OSX? Would you also mind passing along the discogs release ID that you're attempting to tag . I will run a few tests this weekend and hopefully reproduce.

Jesse

fucheeno commented 10 years ago

Thanks so much for getting back to me so quickly. The ID is 735985. ᐧ

Michael 818.378.5880

On Sat, Jun 7, 2014 at 10:39 AM, Jesse Ward notifications@github.com wrote:

Thanks for the report.

Looks like you're on OSX, which version of OSX? Would you also mind passing along the discogs release ID that you're attempting to tag . I will run a few tests this weekend and hopefully reproduce.

Jesse

— Reply to this email directly or view it on GitHub https://github.com/jesseward/discogstagger/issues/21#issuecomment-45416244 .

jesseward commented 10 years ago

should now be resolved.

thanks again for the report. The following was run on OSX 10.9.3

$ discogs_tagger.py -s mp3 -r 735985
INFO:__main__:Using destination directory: mp3
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): api.discogs.com
INFO:discogstagger.discogsalbum:Fetching Aretha Franklin - I Never Loved A Man The Way I Loved You (735985)
INFO:__main__:Tagging album 'Aretha Franklin - I Never Loved A Man The Way I Loved You'
INFO:__main__:Creating destination directory 'Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW'
INFO:__main__:Downloading and storing images

=== ACTION REQUIRED ===
In order to fetch images from discogs, you're required to grant the discogstagger application access to perform actions on behalf of your discogs account.
Please visit http://www.discogs.com/oauth/authorize?oauth_token=UpweexssfkPtQgYOzUqorHwmNBduOAayBomErcex and accept the authentication request
Please enter verification code provided at the above url:Qo00LBBBPZuvrOKHOUSEMUSIC

INFO:__main__:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/01-Aretha_Franklin-Respect.mp3
INFO:__main__:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/02-Aretha_Franklin-Drown_In_My_Own_Tears.mp3
INFO:__main__:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/03-Aretha_Franklin-I_Never_Loved_A_Man_(The_Way_I_Loved_You).mp3
INFO:__main__:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/04-Aretha_Franklin-Soul_Serenade.mp3
INFO:__main__:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/05-Aretha_Franklin-Dont_Let_Me_Lose_This_Dream.mp3
INFO:__main__:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/06-Aretha_Franklin-Baby_Baby_Baby.mp3
INFO:__main__:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/07-Aretha_Franklin-Dr_Feelgood_(Love_Is_A_Serious_Business).mp3
INFO:__main__:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/08-Aretha_Franklin-Good_Times.mp3
INFO:__main__:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/09-Aretha_Franklin-Do_Right_Woman-Do_Right_Man.mp3
INFO:__main__:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/10-Aretha_Franklin-Save_Me.mp3
INFO:__main__:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/11-Aretha_Franklin-A_Change_Is_Gonna_Come.mp3
INFO:__main__:Generating .nfo file
INFO:__main__:Generating .m3u file
INFO:__main__:Tagging complete.
fucheeno commented 10 years ago

OK. Much better but I am not getting the actual images. I am just getting the placeholder images. Did you get the actual artwork? All I get are what I attached ᐧ

Michael 818.378.5880

On Sun, Jun 8, 2014 at 1:36 PM, Jesse Ward notifications@github.com wrote:

should now be resolved.

  • requirements.txt had a typo, missing oauth2 requirement
  • discogsauth.py rep -> resp variable naming.
  • discogs api request user-agent to be set. I was not doing this for oauth requests.

thanks again for the report. The following was run on OSX 10.9.3

$ discogs_tagger.py -s mp3 -r 735985 INFO:main:Using destination directory: mp3 INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): api.discogs.com INFO:discogstagger.discogsalbum:Fetching Aretha Franklin - I Never Loved A Man The Way I Loved You (735985) INFO:main:Tagging album 'Aretha Franklin - I Never Loved A Man The Way I Loved You' INFO:main:Creating destination directory 'Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW' INFO:main:Downloading and storing images

=== ACTION REQUIRED === In order to fetch images from discogs, you're required to grant the discogstagger application access to perform actions on behalf of your discogs account. Please visit http://www.discogs.com/oauth/authorize?oauth_token=UpweexssfkPtQgYOzUqorHwmNBduOAayBomErcex and accept the authentication request Please enter verification code provided at the above url:Qo00LBBBPZuvrOKHOUSEMUSIC

INFO:main:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/01-Aretha_Franklin-Respect.mp3 INFO:main:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/02-Aretha_Franklin-Drown_In_My_Own_Tears.mp3 INFO:main:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/03-Aretha_Franklin-I_Never_Loved_AMan(The_Way_I_Loved_You).mp3 INFO:main:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/04-Aretha_Franklin-Soul_Serenade.mp3 INFO:main:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/05-Aretha_Franklin-Dont_Let_Me_Lose_This_Dream.mp3 INFO:main:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/06-Aretha_Franklin-Baby_Baby_Baby.mp3 INFO:main:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/07-Aretha_Franklin-DrFeelgood(Love_Is_A_Serious_Business).mp3 INFO:main:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/08-Aretha_Franklin-Good_Times.mp3 INFO:main:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/09-Aretha_Franklin-Do_Right_Woman-Do_Right_Man.mp3 INFO:main:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/10-Aretha_Franklin-Save_Me.mp3 INFO:main:Writing file Aretha_Franklin-I_Never_Loved_A_Man_The_Way_I_Loved_You-(20P2-2364)-1988-jW/11-Aretha_Franklin-A_Change_Is_Gonna_Come.mp3 INFO:main:Generating .nfo file INFO:main:Generating .m3u file INFO:main:Tagging complete.

— Reply to this email directly or view it on GitHub https://github.com/jesseward/discogstagger/issues/21#issuecomment-45447777 .

jesseward commented 10 years ago

This commit https://github.com/jesseward/discogstagger/commit/be1343c33fee2f104c384deadc1eba55d82164ac should fix that. Unfortunately I missed the actual request call in get_images. I have verified the appropriate images are now being retrieved.

fucheeno commented 10 years ago

Awesome. It now works. Thanks so much Jesse!! ᐧ

Michael 818.378.5880

On Mon, Jun 9, 2014 at 8:46 PM, Jesse Ward notifications@github.com wrote:

This commit be1343c https://github.com/jesseward/discogstagger/commit/be1343c33fee2f104c384deadc1eba55d82164ac should fix that. Unfortunately I missed the actual request call in get_images. I have verified the appropriate images are now being retrieved.

— Reply to this email directly or view it on GitHub https://github.com/jesseward/discogstagger/issues/21#issuecomment-45570955 .

jesseward commented 10 years ago

Thanks . closing this out