jesseward / discogstagger

Console based audio-file metadata tagger that uses the Discogs.com API v2 (JSON based). Relies on the Mutagen and discogs-client libraries. Currently supports FLAC and MP3 file types.
MIT License
70 stars 13 forks source link

CD No matching in track naming not working #36

Open xytzw opened 7 years ago

xytzw commented 7 years ago

I use song=%DISCNO%-%TRACKNO% %TITLE% in the config file and found that it works half-way. It works for one disc releases, it did work for one release with two discs (sorry, can't remember which one exactly). However, it didn't work for multi-album releases like 8044338. The disc No info is there but I ended up with tracks named 01-01 to 01-forty something instead of 01-01 to 01-10; 02-01 to 02-12 etc. (actually it's 1-01 and not 01-01. Leading zero (as in 01, 02 etc) for disc numbers will be much preferred.)

For the above release I had a folder with 5 sub-folders in it. I found that copy_other_files=True doesn't work for all the 5 folders but only the first one (I also use #discs=-CD to collect all output tracks in one- folder). Moving to Issue #37

Thanks a lot

jesseward commented 7 years ago

Thanks for the report. I have split the copy_other_files issue into a separate bug (issue #37 ) for tracking.

xytzw commented 7 years ago

Glad to help. Could you let me on the query re including disc number into the file's name. Is there something I need to adjust in the config file or is this not supported? It's a really handy way to keep multi-album tracks in one folder and still be able to differentiate between them if needed. It will be great to have it. I also looked at tags written by discogstagger and couldn't see the disk number tag written. It seems this tag is not included. Would it be also possible to see the inclusion of media type (CD, vinyl etc) and ASIN or barcode tags? Those come useful too.

Re the app update - I tried to upgrade to v3.0.1 via the installation instructions in the description (git clone https://github.com/jesseward/discogstagger.git and then python setup.py install) but at the end the script reported back I still have v3.0.0. I'm I missing something during the install process?

Thanks

jesseward commented 7 years ago

Re the app update - I tried to upgrade to v3.0.1 via the installation instructions in the description (git clone https://github.com/jesseward/discogstagger.git and then python setup.py install) but at the end the script reported back I still have v3.0.0. I'm I missing something during the install process?

I had not bumped the on my prior commit. I have done so now. You should see a version 3.0.2 when you install from latest.