search

jesseward / jellyfin-plugin-lastfm

LastFM plugin for the Jellyfin media system. Fork of the Emby Last.FM plug-in
178 stars 11 forks source link

Present a list of LovedTracks that were not able to match (in the log or somewhere else). #24

Open jesseward opened 4 years ago

jesseward commented 4 years ago

This is just nitpicky, but it would be nice to get a list of the songs that were not able to match (in the log or somewhere else).

[04:39:00] [INF] [21] Jellyfin.Plugin.Lastfm.ScheduledTasks.ImportLastfmData: Retrieved 2584 lovedTracks from LastFM for user Odinoss,
[04:38:42] [INF] [26] Jellyfin.Plugin.Lastfm.ScheduledTasks.ImportLastfmData: Syncing LastFM favourties for Odin,
[06:37:37] [INF] [21] Jellyfin.Plugin.Lastfm.ScheduledTasks.ImportLastfmData: Finished Last.fm lovedTracks sync for Odin. Matched Songs: 1932

I'm saying this because I know for a fact that all my lovedtracks are present in my library, but it was unable to match ~600 of them. Would be easier to debug the songs matching if there was a list of unmatched songs.

Originally posted by @OdinGitDat in https://github.com/jesseward/jellyfin-plugin-lastfm/issues/23#issuecomment-668012019

jesseward commented 4 years ago

hey @OdinGitDat, logged this new issue.

The request sounds reasonable, will log a future item here in the event someone wants to pick it up. I suspect there are some songs missed due to the comparison implementation. https://github.com/jesseward/jellyfin-plugin-lastfm/blob/6a29fcdde1ea4c31a5abbe11eed64f9297d37196/Jellyfin.Plugin.Lastfm/Utils/StringHelper.cs#L6-L24

There is no distance or fuzzy matching. So if you have a slight difference in naming such as "remix", "live" or "Artist featuring ...", it will not match.

blers27 commented 3 years ago

To me, this looks like extreme nitpicking whatever the plugin is doing. The plugin retrieved 315 lovedTracks from LastFM and it only matched 5 songs for me. That's a 1.6% match rate :/

jesseward commented 1 year ago

I have added a known issues section to the README and included this issue . See https://github.com/jesseward/jellyfin-plugin-lastfm#known-issues