10.7.0.0 release readiness

jesseward / jellyfin-plugin-lastfm

LastFM plugin for the Jellyfin media system. Fork of the Emby Last.FM plug-in

178 stars 11 forks source link

10.7.0.0 release readiness #30

Closed jesseward closed 3 years ago

jesseward commented 3 years ago

Client/Plugin (API/ABI) Developer Notes for RC1

We have migrated from ServiceStack to ASP.NET. Web API endpoints no longer accept HTTP Form requests; everything must be application/json. NOTE: Plugins that implement endpoints will also have to migrate.
Plugins must now target net5.0.
IHttpClient removal: Now inject IHttpClientFactory instead.
HttpException removal: Now catch HttpResponseException instead.
Services can be registered to the DI pipeline.

jesseward commented 3 years ago

Prep being done in 10.7.0.0 tree (https://github.com/jesseward/jellyfin-plugin-lastfm/commit/150932e6121c02ba9bb3a0ee07bb2a8a1655681a)

kellcomnet2 commented 3 years ago

I know 10.7 is still in RC but do you know/have rough timeline on when the 10.7 version will be available?

jesseward commented 3 years ago

hey @kellcomnet2 : i have pushed plugin version 7.0.0.0 to the Repo. This version supports the 10.7.x RC builds

kellcomnet2 commented 3 years ago

@jesseward thanks, I’ll update tonight.

kellcomnet2 commented 3 years ago

@jesseward I have installed it manually since it didn't show up via the manifest and have enabled it for my music library. Thank you.

jesseward commented 3 years ago

@jesseward I have installed it manually since it didn't show up via the manifest and have enabled it for my music library. Thank you.

thanks @kellcomnet2 , note that the Repo URL changed in October timeframe. Ensure you're using

    Repo name: LastFM Stable
    Repo URL: https://jellyfin-repo.jesseward.com/manifest.json

I had tested a repo based install on 10.7 rc3 (which worked), though didn't attempt an upgrade from an existing version........

EDIT: it appears that the manifest.json is cached at one of the edge nodes. I am purging the cache now, so the manifest.json response should be consistent from here ;-)

kellcomnet2 commented 3 years ago

@jesseward Deleted my last comment as you found the caching issue. Isn't software development fun :) You can have the best code in the world and deployment always has a hiccup.