CS2 Buynds!

[justDeeevin]

Certain key names changed with CS2. This feature adds a dropdown to change between creating CS:GO buynds and CS2 buynds.

[justDeeevin]

Right now the only issue is that the page thinks that the CS2 buynds are separate from the CS:GO buynds. If I assign a command to kp_ins in CS:GO mode then switch to CS2 mode, the commands on kp_ins aren't transferred to its corresponding CS2 key kp_0. Also, when the code is generated, both kp_ins and kp_0 are generated.

I think this is because it tracks commands based on key.bind. Since kp_ins is different from kp_0, it thinks they're two entirely different keys when they're really just different names for the same key. This can be solved by instead using key.code.

I don't currently need help with making this change. Just thought I'd keep this up-to-date.

[justDeeevin]

As of 61cde9a45316de019e8663abd8e6105b75f108b9, the above-mentioned issue is now resolved. However, a new one arises. Changing the game doesn't update the keyname of binds. Binds have to be reset for the key name changes to register.

I've already got ideas to fix this.

[justDeeevin]

With ed4403cbbc7c5e66409ff86253e62e5055191522, CS2-Buynds with the multi-key generator are fully functional!

Now to add it to the single-key generator...

[justDeeevin]

It should be noted that, while swapping between the two modes is fully functional, I'm not certain all the cs2binds are accurate. However, it'll be an easy and (relatively) quick process to make sure since I only need to edit bindable-keys.json.

[justDeeevin]

2adaf4c72bdc178987f309d11a3417736121d52e single-key generator no longer generates on game switch

Maybe we could add an auto-generate toggle for the single-key generator as well? That's not necessary for this PR, though.

[jessewebb]

@ThePyroTF2 Thank you for all the hard work on these changes, it is much appreciated!

I like the approach you took with the drop-down options for CS2. Unfortunately, I don't have access to CS2 quite yet so I can't test this so it makes me slightly nervous to merge it now.

I might merge this functionality in with a "beta" label to warn users it is a work-in-progress, or I might wait until I get access to CS2 so I can test these new binds out before making this public.

Either way, thanks again!

[justDeeevin]

@jessewebb CS2 is weirder than I realized.

I'm going to mark this PR as a draft until I can figure out the rules behind the strange behavior of the buy command. I wouldn't want it merged while the commands it generates are incorrect.

Why, Gaben? Why?!

[justDeeevin]

Alright. Check this out.

I think I'll need to have a separate options menu when in cs2 mode, like an mkg-key-bind-options-cs2.html that is opened instead of mkg-key-bind-options.html when game is set to 'cs2'. Wish me luck.