search

jesseweed / seti-syntax

A subtle dark colored theme for Atom.
MIT License
185 stars 66 forks source link

Wrong syntax highlighting of js reserved words #110

Closed OmgImAlexis closed 8 years ago

OmgImAlexis commented 8 years ago

Both Image and async are highlighted but as far as I know neither are reserved words so there should be no reason for that.

screen shot 2015-11-02 at 3 43 00 pm

jesseweed commented 8 years ago

Hey @OmgImAlexis, so the highlighting is actually defined by the atom/language-javascript package, I just apply a styles based on the classes assigned by that package.

According to the grammar file in that repo, Image gets the same class as Array, Boolean, Date, Function, etc.

And, while I didn't parse through all of the regex rules, as best as I can tell, async gets the same class applied as var, this, constant, class, etc.

I know there's actually a JS api for Image, don't remember on async off the top of my head (I know there's a new async proposal in ES7, but I believe it uses the await keyword).

Anyway, I will double check that everything is being applied appropriately on the Seti side, but I believe it is (the default atom themes all apply styles the same). I'd encourage you to file an issue on the atom/language-javascript repo if you think it's incorrect.

Cheers!

OmgImAlexis commented 8 years ago

@jesseweed thanks for the quick reply. I'll definitely open an issue with them.