jesseweed / seti-syntax

A subtle dark colored theme for Atom.
MIT License
185 stars 66 forks source link

Python unreadable after last update #123

Closed OmgImAlexis closed 7 years ago

OmgImAlexis commented 8 years ago

The first screenshot is a sample of code from about a month ago, I just updated to the latest version of seti-ui and seti-syntax and now most of my files are almost unreadable. Is there anyway to get them close to how they use to be or will I need to manually install an older version of this?

screen shot 2016-04-25 at 1 21 28 pm screen shot 2016-05-03 at 11 18 59 pm

jesseweed commented 8 years ago

Hrm, that is a lot of blue. I'll take a look at it.

justinaray commented 8 years ago

@jesseweed I had a similar problem with markdown files and the new themes.

I "fixed" it by overridding the .source style in my stylesheet to a neutral gray that will be overridden by keyword styling. Seems to help with languages that are considered source but don't have many keywords.

Not sure if this helps here, you have a better suggestion, or the theme could be less aggressive on styling source selectors.

onewhaleid commented 8 years ago

I am having the same problem (python, seti-syntax 1.0.1)

Gaff commented 8 years ago

Glad it's not just me!

@justinaray what exactly did you put in your styles? I have this but it didn't work:

.source {
  color: #D3D3D3;
}
justinaray commented 8 years ago

@Gaff You didn't post the entire block, but I'm betting your rule is not specific enough to override the defaults. In essence, my stylesheet looks like this:

atom-workspace.theme-seti-syntax {
    // ...
    atom-text-editor::shadow {

        // ***** Seti Tweaks *****

        // Mute the default source color unless it's a keyword
        // Helps with keyword-light langs like markdown
        .source {
            color: #babebd;
        }
        // ...
    }
    // ...
}
Gaff commented 8 years ago

@justinaray That is very helpful - thanks! Though it still wasn't perfect highlighting. In the end I decided to use a.n.other theme with the SETI background colour.

Looking forward to the proper fix :)

OmgImAlexis commented 7 years ago

@jesseweed any updates on this?

sihrc commented 7 years ago

+1 for updates?

OmgImAlexis commented 7 years ago

This seems to be usable now. @jesseweed it'd be nice to have issues closed in commits so people know when issues are fixed.

screen shot 2016-12-31 at 3 49 27 pm