jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
941 stars 284 forks source link

Some unreadable buttons #394

Open haabe opened 7 years ago

haabe commented 7 years ago

Some buttons are quite unreadable, such as the install package button (white on [insert Seti-ui color scheme here] doesn't work too well).

Install button

Neither does transparent on blue (or blue on blue) for the Find options.

Regex button

johnhaley81 commented 7 years ago

I erroneously thought this was https://github.com/steelbrain/linter/issues/1361. So the buttons on the "install dependent package" notification are also hard to read.

scragz commented 7 years ago

Came here to see if anyone else was having problems with the blue on blue find options.

scragz commented 7 years ago

You can fix it temporarily by putting this in your styles.less:

@import "ui-variables";
.project-find, .find-and-replace {
  .btn-group {
    .option-regex, .option-case-sensitive, .option-whole-word {
      &.selected {
        color: @seti-primary-text;
      }
    }
  }
}
haabe commented 7 years ago

I haven't really dived into the seti-ui config to examine how it is all set to play together. I found some quick fix for some of the unreadable texts using the yellow theme color:

import "ui-variables";
.project-find, .find-and-replace {
  .btn-group {
    .btn {
      &.selected {
        color: @text-color-highlight;
      }
    }
  }
}

.item-views {
  .pane-item {
    .section-heading-count {
      &.badge {
        color: @black;
      }
    }

    .btn-group {
      .btn{
        &.install-button {
          color: @black;
        }
      }
    }
  }
}
madeddy commented 6 years ago

I can confirm the problem. For me its most noticeable on the install/update page, however other buttons without much bg color area(somehow stronger..) have the issue also. Compare on the green scheme screenshot the package/install buttons to see the effect.

atom_seti_ui_bug atom_seti_ui_bug1

The worst is it with yellow and green, but other bright schemes have it also to a lesser extent. seti-ui-1-10.0

Strange how long some bugs stay around. :) Greets