search

jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
940 stars 284 forks source link

Define @font-family #459

Closed forestgagnon closed 6 years ago

forestgagnon commented 6 years ago

@jesseweed This variable is supposed to be defined by all themes (see https://github.com/atom/atom/blob/master/static/variables/ui-variables.less#L84), and fixes the issue reported in https://github.com/facebook-atom/atom-ide-ui/issues/14. The latest version of atom-ide-ui is breaking for me because it assumes the existence of this variable.

anthonybrown commented 6 years ago

Has this been resolved? I'm still getting the error?

jonyeezs commented 6 years ago

@anthonybrown doesn't look like its merged yet. I recommend to just use another theme for now, or manually configure it on your local installation

francodacosta commented 6 years ago

@all any update on this?

evliu commented 6 years ago

+1 Please merge [:

GoToLoop commented 6 years ago

Well, it is merged but not released yet? O_o

anthonybrown commented 6 years ago

I'm still getting the error ☹️

forestgagnon commented 6 years ago

It was merged but i don't think a new version was released

anthonybrown commented 6 years ago

I made the change locally as well, no more error. Still should be merged though.

jesseweed commented 6 years ago

Hi all, sorry I got busy with other project, thanks for your patience! I just published 1.10.0 which should fix this issue.