Using `Custom Icons` option creates a misalignment on the `Project` Panel

[bsarrant]

Hi All,

Following the upgrade to the 1.10.0 version, I discovered that using the Custom Icons create a strong height misalignment on the Project part, which didn't exist on former versions.

The main consequence is that using this option on project with lots of files, it extends the project height consequently despite the Compact option (see screenshots below).

• Before actioning Custom Icons:

• After actioning Custom Icons

I reproduced this issue on two PCs: one on Windows 7 and the other on Windows 10

Regarding the Dev console, I get the same error pattern (exclude the Git error) when starting atom only

[TsvetomirGeorgiev]

I'm experiencing the same problem using custom icons.

[rshelnutt]

Confirming above. Custom icons option creating large space between listed objects.

[cristian-sima]

Same here

[muram]

Same here.

Is there a way to rollback or downgrade to 1.9.0?

[esechres]

Use the command line: apm install [@package_version] apm install seti-ui@1.9.0

[davehamer]

Following. Literally just installed Atom today, along with Seti-UI. Have turned off custom icons as a nice easy fix.

[rshelnutt]

Played around in dev mode, can confirm it's being caused by the 'seti' font being used for the icons. Character dimensions causing line break at the span.name.icon.icon-file-text::before pseudo

[Atanacius]

Yeah, I experiment also that error glitch... Top of that, it's ugly... and unpratical..

Hahaha..

Anyway, is there any solution other than install previous version of Seti-UI ?

[cristian-sima]

@jesseweed Can you do something? It is really fustrating... :( Thanks

[jesseweed]

Hi sorry guys, I somehow turned my repo notification off, so just catching up on this.

The custom icon options does add slightly more padding, but it shouldn't be that much.

I will continue to troubleshoot, but so far I cannot reproduce it on any of my machines.

If anybody is able to pinpoint the cause, I'm happy to put in a fix.

Bonus point if you submit a PR with the fix ;)

[jesseweed]

Out of curiosity, is everybody experiencing this issue on a Windows machine?

[bsarrant]

That's my case:

• all the tests I proceeded in my initial post were on Windows 7 & Windows 10
• Currently, the issue is still there and closing this issue is not a solution.
• previous version worked nice with no padding issue so maybe there is your investigation trail.

[muram]

@jesseweed I'm running Windows 10 with Atom version 1.24.0

[esechres]

I'm on Windows 10. The 1.9.0 version works and the 1.10.1 version adds an unacceptible padding. I've rolled back to 1.9.0 until a version (for Windows) doesn't add excessive padding.

[che-wf]

I'm seeing it on two Windows 10 machines.

Specs from atom -v (if it helps):

Atom    : 1.24.0
Electron: 1.6.16
Chrome  : 56.0.2924.87
Node    : 7.4.0

[davehamer]

Well, that looks like a Windows issue then :) Same here.

[Rellek]

Experiencing the same issue. I love the custom icons for this theme so I rolled back to 1.9.0 for the time being.

Windows 10, Atom v1.24.0

[captain-awesome]

I too am experiencing this spacing issue. Please advise on how to revert back on Windows 10? Any help is appreciated

[che-wf]

@captain-awesome Check out the comment above (https://github.com/jesseweed/seti-ui/issues/467#issuecomment-363226630)

[jesseweed]

Ok sounds like this is specifically a windows problem. I'll try and get a windows machine and do some testing, I'll let you know when I push an update.

[cristian-sima]

@jesseweed Nothing yet :( ?

[Mootly]

Swapping out just the seti font files for an older version of the same fixes the problem. (Admittedly, at the cost of scrambling all the icons.) Perhaps simply rebuilding the new font files will fix the problem?

Font height is messed up in the Windows font preview as well.

(Oops, someone already noted this above and I missed it.)

[OneBeatxdd]

Same here with the windows machines TT^TT

[Mayshinlyan]

same here with the windows. The problem still exists. Any updates?

[muram]

@jesseweed any update on the fix?

[cristian-sima]

@muram nobody cares about us :(

@jesseweed any hope?

[TsvetomirGeorgiev]

@muram and @cristian-sima, this is an open source project and every contributor is investing his/her own time without any benefit expectation. I think that you would be more than welcome to submit a PR for fixing the issue. In the mean time, is there something particular that you need from the latest version or you cannot live with "1 pending update"?

I'm sure that when someone has un update you will get a notification and there is no need to ask for one twice a day..

I apologise if my tone is being rude but this is going out of control.

P.S. I'm sorry for my crappy english

[Mootly]

Reminder, to roll back to version 1.9, execute the following in the command line:

apm install seti-ui@1.9.0

Or, more generically: apm install [@package_version]

Then the problem goes away, as it does by turning off custom icons for the interval.

[Mootly]

@jesseweed - It looks like the bug in the font file might be the new etherium icon. Got the font height to render correctly in the font viewer when I overwrote it. Don't have the tools to rebuild the font properly tho.

Looks like there is already a related pull request re: etherium in the SVG file ( #465 ).

[Mootly]

Not a real fix because all I did was replace the etherium icon with the eslint icon, but these are the font files I could recreate. Dropped them into seti-ui/styles/fonts/seti/ and I can run 1.10.0 with proper line-heights.

seti.zip

[muram]

@TsvetomirGeorgiev I don't believe that the new update is essential to my day-to-day work and I can live without it, no problem. Is just a habit to have the latest updates installed if possible :)

I agree with you, we should be focusing on solving and contributing to this project as a community. I will do my best (when I've the time) to look into it and provide any feedback/PR if I can find a permanent solution.

Thank you @jesseweed for this awesome theme.

[chroda]

Hello everyone, would be nice to close these duplicated issues and we propose a patch to fix this. @jesseweed what u think?

[Mootly]

So far as I can tell, all that needs fixing is the etherium icon. I attached a zip above with the icon overwritten (not a real fix) in what fonts I could edit. This solved the problem. But I don't have the font tools to actually fix the icon and export to all the appropriate formats.

There is already a pull request (#465) for the fixed SVG file. So it probably just needs to be exported to the various font formats.

And pull request #479 added some new icons, so maybe best to start with that as a base?

[jesseweed]

Hi all, sorry for delays on this! Finally got a Windows machine and am able to reproduce. Will take a look at the above PR and try to get a fix in shortly.

[xCranberry]

Any news on the fix? <3

[jesseweed]

Ok this should finally be fixed in 1.11.0!