search

jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
940 stars 284 forks source link

Selected search result has the same foreground and background color #485

Closed stomvi closed 5 years ago

stomvi commented 6 years ago

I am using seti-ui 1.10.0 along with atom 1.25.0. The selected search result has the same foreground and background color as the following screenshot shows:

screen shot 2018-03-22 at 8 12 09 pm

Mac OS 10.13 atom 1.25.0 seti-ui 1.10.0

stomvi commented 6 years ago

Same situation in the search panel. screen shot 2018-03-23 at 10 55 16 am

bavandrade commented 6 years ago

This may be related to the following definitions in styles/ui-variables.less:

@text-color-selected: @seti-primary;
@text-color-info: @seti-primary;
...
@background-color-selected: @seti-primary;
@background-color-info: @seti-primary;

The problem can also be seen in other places (blue button to the right is unreadable):

Atom Minimap menu

Meanwhile, as a workaround, you can use a custom style to read the selected results of "Find in files":

atom-workspace.theme-seti-ui {
  .list-tree .match-row.selected:before {
    background-color: white;
  }
}
jesseweed commented 5 years ago

I believe this issue should be resolved. Feel free to re-open if you disagree.