search

jesseweed / seti-ui

A subtle dark colored UI theme for Atom.
MIT License
941 stars 284 forks source link

R language icon is very large #507

Closed aeschli closed 5 years ago

aeschli commented 5 years ago

We use the woff font.

The R icon is exceeding its boundaries: image

https://github.com/jesseweed/seti-ui/blob/master/icons/R.svg

yeahok commented 5 years ago

I'll give this a try.

DanTup commented 5 years ago

@aeschli I noticed this was fixed in VS Code even though it's not fixed here yet. Is VS Code maintaining its own font now? I've opened https://github.com/jesseweed/seti-ui/pull/525 to add a Dart icon but I'm not sure if it's still being maintained here based on the dates of some of the open issues/PRs or in VS Code.

aeschli commented 5 years ago

We just made a patch for the R icon. See here: https://github.com/Microsoft/vscode/commit/542375c6d5d77970305c5aadeac26ea9469be5e0

DanTup commented 5 years ago

@aeschli If things aren't being maintained here, is it possible to contribute the new Dart icon into VS Code? My PR has all the files, though probably it'd need the R icon re-patching before committing to Code.

aeschli commented 5 years ago

We don't really want to branch off. There has been regular updates in the past, so I'd suggest we stay patient

DanTup commented 5 years ago

Understood, though it's been 5.5 months since this issue was opened and GH says the last change to master was 7 months ago 😔

bergmeister commented 5 years ago

@aeschli I would like to add an icon to vscode but seeing that this repo seems to have become stale (no issue/PR comments any more) is not great. What do you suggest?

orta commented 5 years ago

This is now merged 👍